Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate the commitizen logo in png & svg format #878

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Recreate the commitizen logo in png & svg format #878

merged 3 commits into from
Nov 30, 2021

Conversation

bromso
Copy link
Contributor

@bromso bromso commented Nov 24, 2021

No description provided.

@bromso bromso mentioned this pull request Nov 24, 2021
@dmwelch dmwelch self-assigned this Nov 29, 2021
@LinusU
Copy link
Contributor

LinusU commented Nov 30, 2021

Awesome!

What is the use case for adding so many different sizes of the same image? Binary files are not great to put in Git because every version of the file gets stored forever and needs to be downloaded every time you git clone. How about keeping just the SVG files in the repository?

@dmwelch
Copy link
Contributor

dmwelch commented Nov 30, 2021

@LinusU Already on it - should have a commit addressing that shortly...

@dmwelch
Copy link
Contributor

dmwelch commented Nov 30, 2021

@bromso I narrowed down the generated sizes according to some very hasty online research. I added 16x16 for the VSCode icon use case, then: 48, 96, 256, 512, 1024. Adding more sizes is trivial, (see line 24 in generate.sh) but I'd rather have more information on use cases.

@LinusU I wanted to set up the Azure pipeline to generate them as build artifacts but not sure if I did that correctly (still learning this tech stack). I avoided using svgexport and went with Python's cairosvg because I don't think the containers on Azure have browsers and testing on Docker locally demonstrated that svgexport requires the browser to render the PNG files.

@bromso
Copy link
Contributor Author

bromso commented Nov 30, 2021

@dmwelch It all sounds good to me. As long as you guys are happy, I'm happy! 😄

@dmwelch dmwelch linked an issue Nov 30, 2021 that may be closed by this pull request
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

@github-actions
Copy link

🎉 This PR is included in version 4.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commitizen Logo in SVG?
3 participants