Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade semantic-release #574

Closed
wants to merge 1 commit into from

Conversation

pvdlg
Copy link

@pvdlg pvdlg commented Oct 1, 2018

I'm a maintainer of semantic-release and I noticed you are using a quite old version. The last version is 15.9.16!

It seems you have a Travis job only for running semantic-release, but all your tests run on Azure Pipeline. semantic-release now works on pretty much any CI, so I removed the Travis config and added a new job on Azure Pipelines that runs semantic-release once all the test are successful.

In order to complete the config you should create 2 secured environment variable on Azure Pipeline:

I never used Azure Pipeline before, so any review and feedback on my changes there would be much appreciated!

@jimthedev
Copy link
Member

@pvdlg Thank you! This is something I was going to work towards as time opened up. Looks like we're currently getting.

screen shot 2018-10-01 at 12 24 21 pm

@pvdlg pvdlg force-pushed the semantic-release-upgrade branch 2 times, most recently from ff6787a to 6be8f07 Compare October 1, 2018 17:37
@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

It should be fixed now!

@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

Og I also noticed that the code coverage is not being uploaded anymore (it was in .travis.yml but Travis is not running anymore). I added it to the azure-pipelines.yml.

@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

Actually I removed the code coverage as it fails with the error unknown service. could not get configuration. I guess the Codecov token must be added to environment variables.

@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

I have error on Window for npm test. No idea why...it doesn't seems related to any change I made. Any idea of what cause the issue?

@jimthedev
Copy link
Member

Thanks for working on this. I will add the codecov token manually. Re: windows testing I noticed this which is why we are currently at an old version while I nail down exactly what we're doing that is causing buggy behavior.

@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

I can look at the issue with Windows. Can you describe quickly what the failing tests are doing?

@jimthedev
Copy link
Member

I think the problem is that during an init we should not use configLoader but rather just blindly use the current directory. During commit however, we must walk up the tree to find the commit so it makes sense to use configLoader. This is just my assessment on first glance.

@pvdlg
Copy link
Author

pvdlg commented Oct 1, 2018

Is this problem happens because semantic-release itself uses commitizen? So adding a dependency that has a config.commitizen.path in it's package.json create the issue?

I noticed that configLoader.load in init.js accepts a cwd option but it's never passed (so it's always process.cwd() that is used). I don't really understand all the code to be honest...

I just wonder why just adding the semantic-release dependency in devDependencies create that issue. IF there is something we can do in semantic-release let me know.

@jimthedev jimthedev closed this Jul 17, 2019
@jimthedev
Copy link
Member

Updated via renovatebot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants