Pre-compiled Commitizen #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2015 19:37
We want to precompile all js files with babel and for simplicity we should keep all source files in the same folder. The test are using `util` but I can't see any real problems with having the tests importing a file inside the src folder
Precompiling all ES6 code to ES5 with babel to gain performance Adding a .nodeignore file as well to ignore the source code and tests files when publishing to npm See commitizen#39
|
Can't wait to look at this. Very exciting. I'm out of town this weekend but will take a look ASAP tonight or tomorrow. Thanks!!!! |
Added a npm-script for watching changes and re-compile the source file
jimthedev
added a commit
that referenced
this pull request
Nov 1, 2015
feat(compile): Precompile ES6 code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the
srcfolder todistand referring thebinfiles todistinstead.I also added a
.npmignorefile to ignore thesrcfolder (amongtestandmeta) when publishing the package.This is kind of hard to test but the scripts inside the
binfolder seams to work fine and if something should have gone wrong I think that it should have blown up big times since I removedrequire('babel/register')from thebinfolder.See issue #39 and #51.