refactor(git): use execa to invoke git #414
Conversation
Use the execa library when invoing git
On my system `stdout` was undeifned and resulted in "Cannot read property 'trim' of undefined". Switching this code to also use execa fixes that issue.
|
Oh shit, I've been actually meaning to suggest this anyhow, but now it seems even more appropriate. How about dropping support for Node.js 0.12? I think that there is a number of reasons in favour of this, first of all Node.js 0.12 is officially unsupported as of 2016-12-31. Also, I don't think that anyone that is using commitizen is actually using that old of a version, or doesn't have the ability to upgrade. As I have understood it, the majority of the still running Node.js 0.x versions are on servers that have been running it for ages; applications that works and that have no benefit of upgrading. When people are developing locally, I think that they are running the latest Stable, or possibly the latest LTS, and this is where the commits will happen. This should probably happen in a major version though 🤔 Another very interesting thing that dropping 0.x would give would be the ability to stop using babel. I think that most of the language features that we are using are already supported natively in Node 4.x. The only exception that I can think of is This is of course all up to you @jimthedev, please give me your thoughts and I'll proceed accordingly 👍 |
|
Let's do this all in 3.0 and drop Node 0.12 support. |
|
Awesome, shall I create a Is this list up to date or do you want something more in? I'll also add dropping 0.12 to that list |
|
Yep, that list should still be good. Add in 0.12 as well. We were thinking about requiring adapters to self import inquirer, do you think we should still do this? I was thinking we could at least provide a patched version of inquirer that writes a warning to stdout if the loaded adapter doesn't require inquirer. This would let adapter authors get PRs about the coming breaking API change. Although we could go make PRs for public adapters, private adapters need a cli based alert. |
BREAKING CHANGE: Node.js 0.12 is no longer supported
|
Yes, I think making a version that prints a deprecation message is very good, no rush in removing it :) |
|
I think deprecating it in 3.x and removing in 4.x sounds good, that way we won't nag anyone that stays on 2.x. Thoughts? also, merging this to the 3.x branch now, I'll start sending some more PRs shortly :) |
|
Perfect! |
No description provided.