Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commit): fix multiline commits with newlines #413

Merged
merged 2 commits into from
Jan 8, 2017

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jan 8, 2017

This refactors args to always be an array, instead of converting it to a string with escaping and quoting. It uses spawn instead of exec which takes an array of arguments instead of a string.

I'm having some other strange issues with my local tests so uploading now to see how CI is...

Also, this fixes #411

@LinusU
Copy link
Contributor Author

LinusU commented Jan 8, 2017

Also, I think that I would like to start using https://github.com/sindresorhus/execa since it will make the code easier to read, but they also have more robust error handling :)

@jimthedev
Copy link
Member

I'm ok with using execa

@LinusU
Copy link
Contributor Author

LinusU commented Jan 8, 2017

Awesome! I'll send a separate PR with execa and some other small refactoring shortly :) merging this for now

btw. I don't think we have ever talked about any "merge policy", I know that you don't have too much time so have been merging things as I see fit. I hope that this is okay, if you want to have some system where we give LGTM or approve commits that would be very fine for me as well 👍

@LinusU LinusU merged commit 825485c into commitizen:master Jan 8, 2017
@LinusU LinusU deleted the fix-multiline-commits branch January 8, 2017 16:51
@jimthedev
Copy link
Member

That'd be great. I am open to a policy if that makes things easier. I generally release asap and am ok with you doing the same. I'm generally opposed to large releases and prefer to be small and nimble.

@LinusU
Copy link
Contributor Author

LinusU commented Jan 8, 2017

That sounds great, I think keeping it as is will work good. I generally merge the smaller things, and stuff that I think that you might want to comment on I'll wait a bit with 👍

I'm generally opposed to large releases and prefer to be small and nimble.

Couldn't agree more 👍

@andreasonny83
Copy link

sorry guys but how can I commit multiline comments after this merge? Can you please mention that in the README file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing windows multiline tests
3 participants