Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update find-node-modules to version 1.0.4 #384

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Nov 12, 2016

This PR fixes a vulnerability with one of the dependencies of the find-node-modules package.

Fixes #374

this fixes a vulnerability with one of its dependencies

Fixes commitizen#374
@LinusU
Copy link
Contributor

LinusU commented Nov 13, 2016

Hmm, any idea why the build is failing?

@beeman
Copy link
Contributor Author

beeman commented Nov 14, 2016

Hi @LinusU , I don't have a clue. The tests run fine locally, both on master and this branch.

Maybe you can try to clear the cache in travis/appveyor? Looking at the open GreenKeeper PR's it looks like more tests are failing, but with different errors.

@jimthedev jimthedev changed the base branch from master to upgrade-find-node-modules-1.0.4 January 4, 2017 05:50
@jimthedev
Copy link
Member

I need to merge master back into this so I'm merging into a different branch for now then will merge it into master. Thanks for the PR!

@jimthedev jimthedev merged commit dd9298f into commitizen:upgrade-find-node-modules-1.0.4 Jan 4, 2017
@jimthedev
Copy link
Member

This is blocked by master. I merged #328 but unfortunately it is without tests so we need to fix that before we can complete this.

@beeman beeman deleted the update-vulnerable-dependency branch January 4, 2017 16:04
@jimthedev
Copy link
Member

All merged!

@beeman
Copy link
Contributor Author

beeman commented Jan 6, 2017

@jimthedev awesome work on this project over the last week! Thanks a lot for maintaining it!

@jimthedev
Copy link
Member

My pleasure and thank you for the kind words. I can't always get to all the issues right now, but eventually I'll get to them 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants