Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported engines to package specification #229

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented May 14, 2016

As discussed in #226, this prevents installation when running Node 0.10

@LinusU
Copy link
Contributor Author

LinusU commented Jun 2, 2016

@jimthedev I cannot figure out why the tests are failing, something with permissions on appveyor, but other pull requests are working and I just rebased this... :(

@jimthedev
Copy link
Member

I'll take a look. Unfortunately this error is appveyor specific (it doesn't happen on travis). Artifacts is the file location where the tests write their files. Sometimes that filesystem gets disconnected or disappears on appveyor during npm install. I'll try re-running this PR in appveyor and contact their support to see if they have any insight.

@jimthedev
Copy link
Member

Looks like re-running it worked. Tests are now running. Sometimes I think that the npm-cache timeout needs to expire. They must blow it away every so often. On travis you can do this manually. On AppVeyor I am not sure if you can.

@jimthedev
Copy link
Member

success. 👍

@LinusU
Copy link
Contributor Author

LinusU commented Jun 2, 2016

Huh, I tried restarting it before as well :S oh well, glad it works now :D

@LinusU LinusU merged commit 3d32fdc into commitizen:master Jun 2, 2016
@LinusU LinusU deleted the patch-2 branch June 2, 2016 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants