Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix test when there is a global configuration #213

Closed
wants to merge 1 commit into from
Closed

fix(tests): fix test when there is a global configuration #213

wants to merge 1 commit into from

Conversation

sarbbottam
Copy link
Contributor

fixed #211

@sarbbottam
Copy link
Contributor Author

@jimthedev could you take a look?

@jimthedev
Copy link
Member

Hi @sarbbottam. My wife's father died so I am not going to be able to look at PRs or issues until at least next week. Just wanted to let you know.

@sarbbottam
Copy link
Contributor Author

Sorry to hear that, may his soul rest in peace.

On Thu, Apr 28, 2016, 8:14 AM Jim Cummins [email protected] wrote:

Hi @sarbbottam https://github.com/sarbbottam. My wife's father died so
I am not going to be able to look at PRs or issues until at least next
week. Just wanted to let you know.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#213 (comment)

@sarbbottam
Copy link
Contributor Author

@jimthedev please have a look when you get time.

@LinusU
Copy link
Contributor

LinusU commented Jun 19, 2016

I think that this can be done in a more clean way, with just one line of code. How about adding this before the for-loop?

// Do not load user specific config when running the tests
if (process.env.npm_lifecycle_event === 'test') return undefined

@jimthedev
Copy link
Member

This was fixed with #405

@jimthedev jimthedev closed this Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fails if I there is global configuration
3 participants