Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(retry): Updated docs to include how to run --retry from a npm script #158

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

lricoy
Copy link
Contributor

@lricoy lricoy commented Mar 11, 2016

To run git-cz with the --retry option from a npm script we need to do: 'npm run -- --retry'

references #132

@lricoy
Copy link
Contributor Author

lricoy commented Mar 11, 2016

@jimthedev @kentcdodds Not sure what you guys think, since it is a cli, but it's just to clarify for newbies, like myself, that are not aware of the need to use double -- to pass args


Please note that the retry cache may be cleared when upgrading commitizen versions, upgrading adapters, or if you delete the `commitizen.json` file in your home or temp directory. Additionally, the commit cache uses the filesystem path of the repo, so if you move a repo or change its path, you will not be able to retry a commit. This is an edge case, but might be confusing if you have scenarios where you are moving folders that contain repos.
Please note that the retry cache may be cleared when upgrading commitizen versions, upgrading adapters, or ifx you delete the `commitizen.json` file in your home or temp directory. Additionally, the commit cache uses the filesystem path of the repo, so if you move a repo or change its path, you will not be able to retry a commit. This is an edge case, but might be confusing if you have scenarios where you are moving folders that contain repos.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ifx should be if

@lricoy
Copy link
Contributor Author

lricoy commented Mar 11, 2016

I updated the docs to try to reflect your notes. I apologize for any grammar or other mistake in advance. Thanks for all the patience guys.

@kentcdodds
Copy link
Member

LGTM

@jimthedev
Copy link
Member

@lricoy Looks great. Can you please rebase to squash these commits into one? Cheers.

There are multiple ways to pass the --retry option to a npm script. This change updates the docs to explain some of them.

references commitizen#132
@lricoy
Copy link
Contributor Author

lricoy commented Mar 14, 2016

@jimthedev done. I hope this is what you meant

@kentcdodds
Copy link
Member

I believe so.

In the future @jimthedev, maybe you could say:

Can you please rebase to squash these commits into one?

👍

@jimthedev
Copy link
Member

@kentcdodds Yes. Good idea. :)

jimthedev added a commit that referenced this pull request Mar 15, 2016
docs(retry): Updated docs to include how to run --retry from a npm script
@jimthedev jimthedev merged commit 9c22353 into commitizen:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants