Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commitizen Logo in SVG? #800

Closed
bromso opened this issue Dec 16, 2020 · 9 comments · Fixed by #878
Closed

Commitizen Logo in SVG? #800

bromso opened this issue Dec 16, 2020 · 9 comments · Fixed by #878

Comments

@bromso
Copy link
Contributor

bromso commented Dec 16, 2020

Can you please make your logo available in SVG?

https://images.opencollective.com/commitizen/logo/256.png

TIA
@bromso
Copy link
Contributor Author

bromso commented Dec 18, 2020

I hope you guys don't mind but I recreated it. I'm pretty new here and I don't have rights to push or make a pull-request. So I've made them available on a shared Google Drive. But would be great if I could push them myself (if you want them of course).

https://drive.google.com/drive/folders/1arGk0Y_fbs4dvz02RUJKZLn_OsfTSm3i?usp=sharing

@gperdomor gperdomor mentioned this issue Mar 30, 2021
Closed
2 tasks
@fsmaia
Copy link
Contributor

fsmaia commented Sep 24, 2021

Up! This would be very helpful in the VSCode integration.

@dmwelch
Copy link
Contributor

dmwelch commented Nov 23, 2021

@bromso plz make a PR and I'd be happy to merge it in for you. If you fork the project, you will be able to make a branch there and create a PR back to here. Thx!

@fsmaia
Copy link
Contributor

fsmaia commented Nov 24, 2021 •
edited
Loading

@bromso, if you want help I can make the PR for you, not only in this repository but in vscode-icons too.

@bromso
Copy link
Contributor Author

bromso commented Nov 24, 2021 •
edited
Loading

@dmwelch @fsmaia I've forked your project, added all the logos in a folder called logo in the root folder of the project. The logos I've added are in different formats (png & svg), colors (original with different colors, white, black & one version of just the "brand blue") & resolutions (PWA icon sizes).

You can find them here in a branch called logo. Now what do I do more to make this happen? 😄
#878

@bromso
Copy link
Contributor Author

bromso commented Nov 24, 2021 •
edited
Loading

@dmwelch @fsmaia You can also take charge of the file, by duplicate it. I recreated the logo in Figma. Thank you for a great tool by the way! ❤️
https://www.figma.com/community/file/1045298312375103142/Commitizen-logo

@dmwelch
Copy link
Contributor

dmwelch commented Nov 28, 2021

Will take a look

@dmwelch dmwelch linked a pull request Nov 30, 2021 that will close this issue
Recreate the commitizen logo in png & svg format #878
Merged
dmwelch added a commit that referenced this issue Nov 30, 2021
@dmwelch
Recreate the commitizen logo in png & svg format (#878)
084b947 
* Recreate the commitizen logo in png & svg format

* refactor(logos): dynamically generate pngs from svg files

re #800

* build(generate.sh): fix existance checking for cairosvg executable in build envs

Co-authored-by: Dave Welch <[email protected]>
@bromso
Copy link
Contributor Author

bromso commented Nov 30, 2021 •
edited
Loading

@dmwelch I've made an issue in https://svgporn.com/ so you guys can get some more exposure hopefully. 😄

gilbarbara/logos#480

@fsmaia
Copy link
Contributor

fsmaia commented Dec 1, 2021

Just opened the PR in vscode-icons:
vscode-icons/vscode-icons#2869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recreate the commitizen logo in png & svg format
3 participants
@dmwelch @fsmaia @bromso