Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from ghooks [deprecated] to husky? #410

Open
jimthedev opened this issue Jan 2, 2017 · 4 comments
Open

Migrate from ghooks [deprecated] to husky? #410

jimthedev opened this issue Jan 2, 2017 · 4 comments
Labels
0 - Backlog cli dependency related enhancement help / pr wanted pending release
Milestone
5.0.0

Comments

@jimthedev
Copy link
Member

https://github.com/gtramontina/ghooks is deprecated. We should probably switch to husky. https://www.npmjs.com/package/husky
@jimthedev jimthedev added this to the 3.0.0 milestone Jan 9, 2017
@jimthedev
Copy link
Member Author

@LinusU this can also probably go into 3.0 as well.

@LinusU
Copy link
Contributor

LinusU commented Jan 9, 2017

Sounds good 👌

jimthedev added a commit that referenced this issue Jan 9, 2017
@jimthedev
fix(hooks): remove ghooks in favor of husky
bc2b6cb 
This replaces ghooks with husky. ghooks is deprecated in favor of husky. Contributors may need to

For commitizen developers, you need to do the following:

1. rm -rf .git/hooks
2. rm -rf node_modules
3. run npm install.

Closes #410
@jimthedev
Copy link
Member Author

@LinusU I merged this into 3.x. Assuming tests pass, it should be ready to go.

For reference, there are a few steps we need to take for husky to take over from ghooks.

For commitizen developers, you need to do the following:

1. rm -rf .git/hooks
2. rm -rf node_modules
3. run npm install.

@jimthedev
Copy link
Member Author

Tests passed. GTG.

@marionebl marionebl mentioned this issue Nov 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog cli dependency related enhancement help / pr wanted pending release
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@jimthedev @LinusU