-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easter isn't listed as a holiday for DE-HE 2021 #361
Comments
Hi @pmlk, I have check the data in DE.yaml but there has not been an attribution on easter for Hessen so far. |
I'd be happy to file a PR, but I would need some help as I don't quite understand the syntax in the yaml files. Also, I do see something for easter for DE-HE: https://github.com/commenthol/date-holidays/blob/master/data/countries/DE.yaml#L200 As said, it did show up before version |
Hi @pmlk , |
Awesome! Thank you! According to Wikipedia Pentecost is also a public holiday in Hessen. So that looks good to me 👍 Thank you so much! 🙏 |
fix(DE-HE,#361): easter and pentecost are public holidays
This issue came up after upgrading from
3.8.0
to3.16.7
. It seems to have started with version3.15.0
3.14.5
.This may be related to #14, since Easter is always on a Sunday, it may not be considered a holiday. However, "2. Weichnachtstag" was also on a Sunday in 2021, but it is listed as a holiday. So if excluding all Sundays were a rule, it seems to be a bit inconsistent.
The text was updated successfully, but these errors were encountered: