Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easter isn't listed as a holiday for DE-HE 2021 #361

Closed
pmlk opened this issue Oct 5, 2022 · 4 comments
Closed

Easter isn't listed as a holiday for DE-HE 2021 #361

pmlk opened this issue Oct 5, 2022 · 4 comments

Comments

@pmlk
Copy link

pmlk commented Oct 5, 2022

This issue came up after upgrading from 3.8.0 to 3.16.7. It seems to have started with version 3.15.0 3.14.5.

This may be related to #14, since Easter is always on a Sunday, it may not be considered a holiday. However, "2. Weichnachtstag" was also on a Sunday in 2021, but it is listed as a holiday. So if excluding all Sundays were a rule, it seems to be a bit inconsistent.

@commenthol
Copy link
Owner

Hi @pmlk, I have check the data in DE.yaml but there has not been an attribution on easter for Hessen so far.
If easter shall be added for DE-HE, please consider filing a PR.

@pmlk
Copy link
Author

pmlk commented Oct 12, 2022

I'd be happy to file a PR, but I would need some help as I don't quite understand the syntax in the yaml files.

Also, I do see something for easter for DE-HE: https://github.com/commenthol/date-holidays/blob/master/data/countries/DE.yaml#L200

As said, it did show up before version 3.14.5, but I don't quite understand why it vanished.

@commenthol
Copy link
Owner

Hi @pmlk ,
I created PR#365 which should fix the issue. I would also consider Pentecost as public holiday then.
Please advise if changes are required.

@pmlk
Copy link
Author

pmlk commented Oct 22, 2022

Awesome! Thank you! According to Wikipedia Pentecost is also a public holiday in Hessen. So that looks good to me 👍

Thank you so much! 🙏

commenthol added a commit that referenced this issue Nov 2, 2022
fix(DE-HE,#361): easter and pentecost are public holidays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants