Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camerad: merge thread functions into one #33025

Merged
merged 1 commit into from
Jul 25, 2024
Merged

camerad: merge thread functions into one #33025

merged 1 commit into from
Jul 25, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jul 19, 2024

Merge the four thread functions:
processing_thread(),
process_road_camera(),
process_driver_camera(),
start_process_thread()
into one :
CameraState::run()

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@deanlee deanlee changed the title cameraed: merge thread functions into one camerad: merge thread functions into one Jul 19, 2024
adeebshihadeh
adeebshihadeh reviewed Jul 20, 2024
View reviewed changes
Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

system/camerad/cameras/camera_qcom2.cc Outdated Show resolved Hide resolved
system/camerad/cameras/camera_qcom2.cc Outdated Show resolved Hide resolved
@deanlee deanlee marked this pull request as draft July 21, 2024 13:07
@deanlee deanlee force-pushed the camerad_refactor_thread branch 5 times, most recently from f407153 to 074ed52 Compare July 25, 2024 20:28
@deanlee deanlee marked this pull request as ready for review July 25, 2024 21:07
@adeebshihadeh
Copy link
Contributor

trigger-jenkins

@adeebshihadeh adeebshihadeh merged commit ccd369e into commaai:master Jul 25, 2024
17 of 18 checks passed
@deanlee deanlee mentioned this pull request Jul 26, 2024
Merged
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
@deanlee
camerad: merge thread functions into one (commaai#33025)
01ac526 
merge multiple thread functions into one
old-commit-hash: ccd369e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh