Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Add FW Versions for Staria 2024 #32832

Closed
wants to merge 2 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

Add firmware versions for the Hyundai Staria 2024. Expand supported model-year range up to 2024.

Route
6e25dbed0748e26a/00000001--50344558ed

Thanks to the community 2024 Hyundai Staria owner ciapek4473 (Discord).

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sunnyhaibin sunnyhaibin changed the title Staria 2024 fw Hyundai: Add FW Versions for Staria 2024 Jun 25, 2024
@@ -1158,6 +1158,7 @@
CAR.HYUNDAI_STARIA_4TH_GEN: {
(Ecu.fwdCamera, 0x7c4, None): [
b'\xf1\x00US4 MFC AT KOR LHD 1.00 1.06 99211-CG000 230524',
b'\xf1\x00US4 MFC AT EUR LHD 1.00 1.04 99211-CG000 210819',
Copy link
Contributor

@sshane sshane Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wth is this date code starting to be 🤔 @sunnyhaibin can you check what's going on? the VIN suggests 2023 too

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants