Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch3 arguments support #32700

Closed

Conversation

andiradulescu
Copy link
Contributor

This is a proposal to supporting arguments for watch3. This is what watch3 -h says with this PR:

Usage: selfdrive/ui/watch3 [options]

Options:
  -h, --help      Displays help on commandline options.
  --help-all      Displays help including Qt specific options.
  --cams <0,1,2>  cameras to decode, separated by a comma
  --nav           decode nav
  --qcam          decode qcamera
  --ecam          decode wide road camera
  --dcam          decode driver camera

Not using any argument, works as before.

Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

}
QCommandLineParser cmd_parser;
cmd_parser.addHelpOption();
QCommandLineOption cams_option = QCommandLineOption("cams", "cameras to decode, separated by a comma", "0,1,2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s just stick to the individual flags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. also added --cams since that's how it's done in compressed_vipc.py.

should I also post another PR changing compressed_vipc.py to individual flags?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@adeebshihadeh adeebshihadeh marked this pull request as draft June 12, 2024 18:25
@deanlee
Copy link
Contributor

deanlee commented Jun 17, 2024

I'm not quite clear on the purpose of this PR. Watch3 isn't standalone, it relies on Replay for video decoding and camera control. For example, using replay --demo -ecam --dcam displays three videos in Watch3, whereas replay --demo shows only one. Therefore, specifying decoding arguments in Watch3 doesn't actually determine which camera gets decoded; its primary function is to hide the unwanted camera views. automating this through VisionIpcClient::availableStreams would be more efficient.

@andiradulescu
Copy link
Contributor Author

Totally correct: to be able to "show"/"hide" a specific camera. Or a set of two cameras, etc. Since showing just one camera in a 2x2, it's very small and with 3 empty "slots".

The idea to dynamically show the cameras based on VisionIpcClient::availableStreams is much nicer, indeed.

And yes, I naively copy-pasted the help descriptions:
--qcam decode qcamera
when I should've named them correctly:
--qcam show qcamera.

Thanks!

Copy link
Contributor

github-actions bot commented Jul 2, 2024

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants