Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyundai BSM signals #1782

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Add Hyundai BSM signals #1782

merged 3 commits into from
Jun 26, 2020

Conversation

xps-genesis
Copy link
Contributor

to take advantage of BSM to block lane change when BSM active.

to take advantage of BSM to block lane change when BSM active.
@adeebshihadeh
Copy link
Contributor

Can you add LCA11 to the can parser checks?

previous check failed, fixed by adding LCA11 to canparser
@xps-genesis
Copy link
Contributor Author

xps-genesis commented Jun 26, 2020

not sure why it failed the process replay check. can you check? @adeebshihadeh

@scottadair
Copy link
Contributor

Just wanted to confirm that these changes do indeed work on my Palisade

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jun 26, 2020

The references for the process replay test needed to be updated since some of the blindspot values in carState changed for hyundai, as expected.

@adeebshihadeh adeebshihadeh merged commit 57f2996 into commaai:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants