-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mill-mima to check binary compatibility #255
Conversation
build.sc
Outdated
def mimaPreviousArtifacts = Agg.from( | ||
VcsVersion | ||
.vcsState() | ||
.lastTag | ||
.map(lastTag => ivy"com.lihaoyi::utest::$lastTag") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes mimaReportBinaryIssues
check for binary compatibility with the last tag on Git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As a first step. I think later, maybe after the next major release, we want to check against all versions, esp. the first of a major release.
@lefou Isn't it the point of major releases to be breaking and without binary compatibility guarantees? Or do you mean that, for example, |
I meant, that we may need to configure more than one version, not only the last tag. As you already suggested, for |
Warning: currently used mill version in this repo is 0.9.6-xx but mill-mima requires mill 0.9.8! |
Another nice thing to check would be forward compatibility for patch releases, but for that, the plugin should be smarter, I guess. |
974a893
to
9812173
Compare
I'm experiencing a strange error. Locally the
@lefou Have you ever experienced this? |
This is probably because GH by default does not check out the full history but only some (50?) commits. If your tag is more commits in the past, you won't see any tags. To change, add the - uses: actions/checkout@v2
with:
fetch-depth: 0 |
@lefou Gotcha! Thank you! |
Thank you for the reviews! |
I developed this plugin so we can check our ecosystem and avoid breakages of binary compatibility.
I think that at the point of maturity this ecosystem is, we should start to check for binary compatibility and avoid breaking it.
Let me know what you think :)