Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case class default parameter detection and annotation detection in Scala3 #88

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Aug 8, 2023

Fixes #33, as well as @arg annotations not working on case class arguments (which doesn't have an open issue)

Just need some special casing for apply/<init>, both for getting the apply defaults (which are named <init>$default$n since they're shared) and for getting the apply parameter annotations (which end up on the <init> method parameters, rather than the apply method)

Re-enabled a bunch of previously-disabled tests, and added a new suite to exercise default parameters in direct/nested scenarios

@lihaoyi lihaoyi changed the title Fix class default parameter detection in Scala3 Fix case class default parameter detection and annotation detection in Scala3 Aug 8, 2023
@lihaoyi lihaoyi requested review from lefou and lolgab and removed request for lefou August 8, 2023 04:07
@lihaoyi lihaoyi merged commit cd1fdae into main Aug 8, 2023
4 checks passed
@lihaoyi lihaoyi deleted the class-default-scala3 branch August 8, 2023 09:15
@lefou lefou added this to the after 0.5.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default values in case classes in Scala 3
2 participants