-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hopefully this should add our filter list to the site #2465
Hopefully this should add our filter list to the site #2465
Conversation
can someone please help us with this? I don't think it's working ~Red |
I recently got back from a long vacation and am still catching up on things. I'll review and assist where I can soon. Thanks! |
blocked by #2382 |
Wait I don't think I did this right, I thought it was pushing to our fork. ~Charlie |
I think your change is all fixed up and good to go now. I'm going to keep this open for a tad longer to try to fix #2382 which is blocking a few other PRs as well. Nothing else you need to do at the moment but give me a bit of patience. Thanks! |
Thank you. So to update the filter list do we have to mess with anything in the FilterLists repo or do we just update it in our own repo? ~Red |
You did the right thing here. Fork the FilterLists repository. Make changes to the .json files. Submit a Pull Request back into this FilterLists repo. 👍 |
Fork it for every update, got it. Which JSON files would we have to modify to update our list? Still confused on that 😅 ~Charlie |
Hmm, I'm not totally sure I understand your question. So, FilterLists is just a directory of "meta"-information about lists. So, yes, if you have a change to your list such as maybe your contact email address changes, you can certainly submit a PR to the FilterLists repo changing any data in here. A few other links that could be useful:
^this process is certainly difficult and painful. eventually, we hope to make it easier using something like #372 |
Like if I add new URLs would we have to do that? ~Charlie |
No, you don't need to update anything in the FilterLists repo every time rules are added to your list. |
Mmm, sorry, we got some merge conflicts now due to multiple PRs happening at once. I can try to help fix when I have time. |
Alright, we'll wait ~Red |
Hey uh... Is our list going to be added soon? There doesn't seem to have been an update on this in months. ~Red |
I haven't had a chance. Sorry. It'll be at least another week before I have time, but feel free to look into it if you have time. we just gotta resolve the merge conflict. |
Co-authored-by: Collin M. Barrett <[email protected]>
Co-authored-by: Collin M. Barrett <[email protected]>
Co-authored-by: Collin M. Barrett <[email protected]>
Co-authored-by: Collin M. Barrett <[email protected]>
We didn't do it before because the data model thing and the process in general is intimidating. Hopefully this works and this list is useful to people. We're still working on it and are still confused as to how we update our list once it's on the site (do we just edit our list like we normally do and it should work fine? or do we have to edit a json file when we do?). ~Red