Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Active Record 5.2 to be used #154

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

pixeltrix
Copy link
Contributor

Also bump the Ruby versions tested against.

@pixeltrix
Copy link
Contributor Author

Apart from the rubocop failure it looks like it's failing to install the delayed_job gem because the released version still depends on < 5.2. Hopefully when/if collectiveidea/delayed_job#1023 is merged and released then they'll pass.

gem 'rspec', '>= 2.11'
gem 'simplecov', :require => false

gem 'activerecord', "~> 5.1.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is correct this version? ~> 5.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh so many numbers - will fix

Also bump the Ruby versions tested against.
@FanaHOVA
Copy link

Is this working for you? It looks like delayed_job still makes the build fail. 5.2.rc2 works fine though.

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    delayed_job_active_record was resolved to 4.1.2, which depends on
      delayed_job (< 5, >= 3.0) was resolved to 3.0.5, which depends on
        activesupport (~> 3.0)

    rails (= 5.2.0) was resolved to 5.2.0, which depends on
      activesupport (= 5.2.0)

@wnm
Copy link

wnm commented Apr 12, 2018

@FanaHOVA this pr in delayed_job must be merged before. currently delayed_job depends on activesupport ~> 3.0

@pixeltrix
Copy link
Contributor Author

@wnm technically it's >= 3.0, < 5.2 which means that it works with 5.2 RC gems but not the final version. 🤦‍♂️

@guillaumewrobel
Copy link

DelayJob pull request is merged into master! Lets update to Rails 5.2 💯

@albus522
Copy link
Member

Has a couple of issues but I'll take it from here

@albus522 albus522 merged commit 87a00ac into collectiveidea:master Apr 13, 2018
@toao
Copy link

toao commented Apr 13, 2018

@albus522 thanks for merging, looking forward to the release once the remaining issues are resolved 👍

@dillonwelch
Copy link

Is there a list/issues/PRs for the other items that are needed before this can be bumped on Rubygems?

@albus522
Copy link
Member

It is out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants