Added PostGIS to the available addapters for reserve_with_scope method #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into this issue yesterday. Any chance we can get this merged? |
|
Any updates on this? |
|
I've encountered this as well, any way we can get this merged in? |
|
@laserlemon can we get this merged? |
|
@albus522 Seems legit! |
|
No tests to verify, so I really can't say either way. |
|
It seems as though this will maintain backwards compatibility for all non-PostGIS adapters, so I'll lean on the expertise of these fine PostGIS users. Thank you! |
|
Can this be released, this is a very subtle issue and can have big impact on users (eg we are sometimes sending out duplicate emails) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems with jobs getting executed twice (or nr. of running workers times). The problem was that it was using the old way to reserve jobs (which still has this problem and IMO should be removed) because I'm using PostGIS adapter.
Would be nice to pull this in, so I can use the gem again instead of my fork.