Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quiet mode working incorrectly when ENV['QUIET'] was not set #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanrealscout
Copy link

In our environment we were seeing duplicated log entries in Loggly that looked like this:

2017-06-22 16:20:57.598 2017-06-22T16:20:57-0700: [Worker(host:436c039f-cf12-4c5b-93b8-4fd517b2c2ea pid:4)] Job Module#partial_update_bulk_index (id=71153821) RUNNING{ http: { clientHost: "54.90.183.112", contentType: "application/logplex-1" }, syslog: { severity: "Informational", appName: "app", host: "host", procid: "elasticindex.3", priority: "190", facility: "local use 7", timestamp: "2017-06-22T23:20:57.598127+00:00" } }
2017-06-22 16:20:57.598 [Worker(host:436c039f-cf12-4c5b-93b8-4fd517b2c2ea pid:4)] Job Module#partial_update_bulk_index (id=71153821) RUNNING{ http: { clientHost: "54.90.183.112", contentType: "application/logplex-1" }, syslog: { severity: "Informational", appName: "app", host: "host", procid: "elasticindex.3", priority: "190", facility: "local use 7", timestamp: "2017-06-22T23:20:57.598060+00:00" } }

Despite what looked like correct settings, it turns out that if ENV['QUIET'] is not set when starting Delayed Job via rake jobs:work, Delayed::Worker doesn't default @quiet to true. It appears the intended behavior is to default to true if ENV['QUIET'] is not set, so this change fixes this bug.

I could be reading the code wrong, let me know, thanks!

@jacobjlevine
Copy link

This is still an issue. Can we make this happen?

@mjobin-mdsol
Copy link

Shall we expect a release with this patch in ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants