Fix quiet mode working incorrectly when ENV['QUIET'] was not set #987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment we were seeing duplicated log entries in Loggly that looked like this:
Despite what looked like correct settings, it turns out that if ENV['QUIET'] is not set when starting Delayed Job via
rake jobs:work
,Delayed::Worker
doesn't default@quiet
totrue
. It appears the intended behavior is to default to true if ENV['QUIET'] is not set, so this change fixes this bug.I could be reading the code wrong, let me know, thanks!