Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicity about WorkerTimeout Exception #956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amaierhofer
Copy link

@amaierhofer amaierhofer commented Nov 18, 2016

Currently the Delayed::WorkerTimeout Exception is confusing. It only considers Delayed::Worker.max_run_time for its message, even though the timeout might have been caused by max_run_time set on the particular job. This has already been described in #794

This PR adjusts the message to give more details about which of the two timeouts caused the error. This

@coveralls
Copy link

coveralls commented Nov 18, 2016

Coverage Status

Coverage increased (+0.1%) to 91.233% when pulling 435af12 on amaierhofer:less_confusing_timeout_error into e3772d4 on collectiveidea:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.233% when pulling 435af12 on amaierhofer:less_confusing_timeout_error into e3772d4 on collectiveidea:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.233% when pulling 435af12 on amaierhofer:less_confusing_timeout_error into e3772d4 on collectiveidea:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.233% when pulling 435af12 on amaierhofer:less_confusing_timeout_error into e3772d4 on collectiveidea:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.233% when pulling 435af12 on amaierhofer:less_confusing_timeout_error into e3772d4 on collectiveidea:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants