don't include ClassMethods with MessageSending #924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves
Delayed::ClassMethods
out ofDelayed::MessageSending
becauselib/delayed_job.rb
includesDelayed::MessageSending
intoObject
, andthat has the side-effect of defining
ClassMethods
in everyObject
I discovered this issue when finding out that rails wouldn't autoload a file named
class_methods.rb
in a different project. This bug definesClassMethods
for everyObject
, which prevents rails' autoloader from triggering andrequire
ing respectively named files.