Catch errors deserializing marshalled objects

[afn]

fixes #906

[coveralls]

Coverage increased (+0.03%) to 91.153% when pulling 5e922ea on afn:issue-906 into 401f43e on collectiveidea:master.

[JackDanger]

I recommend rescue => error because Exception is a little too greedy and catches, for example, CTRL-C-ing the process. Leaving out the exception class implies rescue StandardError => error.

[afn]

Unfortunately Ruby raises an Exception, not an Error, when attempting to
unmarshal a Delegator with no setobj :(

On Friday, April 15, 2016, Jack Danger Canty [email protected]
wrote:

In lib/delayed/psych_ext.rb
#907 (comment)
:

@@ -74,7 +74,11 @@ def visit_Psych_Nodes_Mapping(object) # rubocop:disable CyclomaticComplexity, Me
raise Delayed::DeserializationError, "DataMapper::ObjectNotFoundError, class: #{klass} (#{error.message})"
end
else

•      super
  

•      begin
  

•        super
  

•      rescue Exception => error
  

I recommend rescue => error because Exception is a little too greedy and
catches, for example, CTRL-C-ing the process. Leaving out the exception
class implies rescue StandardError => error.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/collectiveidea/delayed_job/pull/907/files/5e922eacee9dda00c4316badfce6d9edafcfe208#r59939272

[albus522]

Is there a specific error that can be caught?

[afn]

We could catch ScriptError instead; this is the superclass of NotImplementedError (the one that's thrown for this particular case) as well as SyntaxError and LoadError

[afn]

I've changed this to catch ScriptError instead of Exception.