Provide ability to add signals that may stop the job. #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@albus522 Any chance to merge this? Would be very helpful for as we'd like to react on |
johha
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Feb 13, 2023
Adds a monkey patches to delayed_job workers to gracefully shutdown in case of a `QUIT` signal. So far delayed_job only considered `INT` & `TERM` signals for graceful shutdown. This might become obsolete once the following change is merged into delayed_job. See collectiveidea/delayed_job#900 To ensure that a version bump of delayed_job does not break the monkey patch a test will fail in case the version number changes. In case of a version bump it needs to be manually verified if the monkey patch still works. Co-authored-by: Philipp Thun <[email protected]> Co-authored-by: Sven Krieger <[email protected]> Co-authored-by: Johannes Haass <[email protected]>
johha
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Feb 13, 2023
Adds a monkey patches to delayed_job workers to gracefully shutdown in case of a `QUIT` signal. So far delayed_job only considered `INT` & `TERM` signals for graceful shutdown. This might become obsolete once the following change is merged into delayed_job. See collectiveidea/delayed_job#900 To ensure that a version bump of delayed_job does not break the monkey patch a test will fail in case the version number changes. In case of a version bump it needs to be manually verified if the monkey patch still works. Co-authored-by: Philipp Thun <[email protected]> Co-authored-by: Sven Krieger <[email protected]> Co-authored-by: Johannes Haass <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise_signal_exceptionsclass attribute accessor toraise_exceptions_for_signals.raise_signal_exceptions = false.:termsignal, change has been made to raise exception ifraise_exceptions_for_signalsarray has the signal code.INTandTERMsignals are considered. Added change to provide ability of adding more signals (like 'QUIT'), whose receipt can end the job.INTandTERMsignals always considered.