Do not log job removed when destroy_failed_jobs? is false #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worker incorrectly logs that the job is removed when destroy_failed_jobs? is false
|
Why did the check fail? This is quite a trivial change. |
|
Because you now have 2 failed tests. |
|
How can I see which tests fail? I've only modified a tiny bit of code on one line (see my commit). |
|
Click through to any one of the individual parts of the build |
|
Thanks. Could you perhaps give me a hand in fixing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker incorrectly logs that the job is removed when destroy_failed_jobs? is false