Allow backends to support find-and-lock in a single request #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds find-and-lock semantics to the active record backend and modifies the worker to use this method when the backend supports it. The idea is to allow workers to synchronize on the underlying database when the database supports it. As we've scaled out our worker count we've found contention between workers trying to lock jobs is a serious problem and generates a lot of extra query traffic in the current implementation. InnoDB's row level locks can instead be used to synchronize the worker polling so that each worker is guaranteed to get a lockable job, or none at all.
We haven't finished testing this yet but I'd like to start gathering feedback.