Namespace Configuration Env Vars with Backwards Compatibility #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1028.
Namespace all configuration variables used by Delayed::Job under the
DELAYED_JOB_
-prefix.This will allow developers to easily figure out what the env var is used for at a glance and prevent collisions with other libraries using similarly named variable names.
Allow non-namespaced configuration variables as a fallback, but with a deprecation warning.
Example usages:
With deprecated vars:
With namespace vars: