Improved reloading #1022
Open
Improved reloading #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting and I want to take a deeper look into it, but I don't have the time at this moment. |
…mproved_reloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code reloads the Rails app every 5 seconds (default wait time).
This is not necessary, as the reload only needs to happen when there are jobs to run.
I modified the code to check if there are jobs to run by adding a
jobs_to_run?method which checks to see if the backend has implemented this method. If the method is not implemented by the backend, then the reloading will happen every 5 seconds as it used to.If the backend has implemented the method, then reloading will only happen when there are jobs to run.
This is similar to when Rails reloads the code, only when there is a web request and not every X seconds.
I have opened a pull request with
delayed_job_active_recordto add the method: collectiveidea/delayed_job_active_record#153