Merge pull request #877 from sharetribe/dont-mutate-opts

Don't mutate the options hash
collectiveidea · Mar 31, 2017 · 263123b · 263123b
2 parents ccbde3d + fd8ad9c
commit 263123b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/delayed/backend/job_preparer.rb b/lib/delayed/backend/job_preparer.rb
@@ -4,7 +4,7 @@ class JobPreparer
  attr_reader :options, :args
 
  def initialize(*args)
- @options = args.extract_options!
+ @options = args.extract_options!.dup
  @args = args
  end
 

diff --git a/lib/delayed/backend/shared_spec.rb b/lib/delayed/backend/shared_spec.rb
@@ -113,6 +113,13 @@ def create_job(opts = {})
  job = described_class.enqueue M::ModuleJob.new
  expect { job.invoke_job }.to change { M::ModuleJob.runs }.from(0).to(1)
  end
+
+ it 'does not mutate the options hash' do
+ options = { priority: 1}
+ job = described_class.enqueue SimpleJob.new, options
+ expect(options).to eq({ priority: 1 })
+ end
+
  end
 
  context 'with delay_jobs = false' do