fix for move_to_child_with_index method #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when moving a node downward (but not to the bottom) within its current parent the `move_to_child_with_index` method would insert the node in the wrong place. This is because when moving a node downward the positioning needs to take into account the fact that the moving node is being removed from its current position. also, add code to handle a no-op call -- moving a node to the position it's already at -- w/o raising an error.
|
@parndt any thoughts? |
|
Seems good to me 😄 |
parndt
added a commit
that referenced
this pull request
Jun 29, 2014
…_index fix for move_to_child_with_index method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when moving a node downward (but not to the bottom) within its current parent the
move_to_child_with_indexmethod would insert the node in the wrong place.This is because when moving a node downward the positioning needs to take into account the fact
that the moving node is being removed from its current position.
also, add code to handle a no-op call -- moving a node to the position it's already at -- w/o raising an error.