use nsid 0 when sending NVME_ADMIN_IDENTIFY command. fixes collectd/collectd/#4127 #4128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: smart plugin: using NSID 0 when issuing the Identify Admin command, otherwise FireCuda 530 ssd logs an error.
I managed to narrow down the problem to the smart.c file using NSID 0xFFFFFFFF when sending the Identify Admin command.
Far from being an expert in NVME, I found this code https://www.smartmontools.org/static/doxygen/nvmecmds_8cpp_source.html#l00134 which sends the command using NSID argument with value 0.
This indeed causes no more problems with the FireCuda 530 hard disk adding errors when queried.