Fix url encoding for PKs with url-unsafe characters (like slashes) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a PK has slashes (eg, a file path), they are not encoded properly and break Flask routing. For example, a PK value of `/tmp/foo` will route to `/table_name/update/tmp/foo`. Flask provides `url_map.converters['path']` for this, EXCEPT that the `path` converter still won't touch a leading slash, which needs to be encoded for this particular example. Rather than worrying about what characters need to be url-encoded, or whether they are at the start or end of a param, etc, just base64 the PK value so no matter what is in there, it's url-safe. http:https://exploreflask.com/en/latest/views.html#custom-converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PK has slashes (eg, a file path), they are not encoded properly and break Flask routing. For example, a PK value of
/tmp/foowill route to/table_name/update/tmp/foo.Flask provides
url_map.converters['path']for this, EXCEPT that thepathconverter still won't touch a leading slash, which needs to be encoded for this particular example.Rather than worrying about what characters need to be url-encoded, or whether they are at the start or end of a param, etc, just base64 the PK value so no matter what is in there, it's url-safe.
http:https://exploreflask.com/en/latest/views.html#custom-converters