General cleanup and bugfixes #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run the Black formatter, and fixed a bunch of linting errors in pylint and flake8.
I was also able to find an error in the export(Methods in the wrong order) and another in the error handling(name should have been rename) function thanks to the linters.
I've removed the * import to Peewee, as it makes the linters unhappy and unable to detect undefined.
I've eliminated the migrator global, it doesn't seem to be used enough to warrant having a global.
I've also replaced most references to dataset with a get_dataset() call, as I believe that will make future refactoring and features easier.