Raise OperationalError when close() is called while txn active.

coleifer · Feb 22, 2018 · f40ec03 · f40ec03
1 parent 207a4c5
commit f40ec03
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/peewee.py b/peewee.py
@@ -2443,6 +2443,9 @@ def close(self):
  if self.deferred:
  raise Exception('Error, database must be initialized before '
  'opening a connection.')
+ if self.in_transaction():
+ raise OperationalError('Attempting to close database while '
+ 'transaction is open.')
  is_open = not self._state.closed
  try:
  if is_open:

diff --git a/tests/transactions.py b/tests/transactions.py
@@ -157,3 +157,7 @@ def also_fails():
 
  with db.manual_commit():
  self.assertRaises(ValueError, also_fails)
+
+ def test_closing_db_in_transaction(self):
+ with db.atomic():
+ self.assertRaises(OperationalError, db.close)