Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped an argument in parentheses to silence JRuby "Ambiguous First Argument" warnings #7

Merged
merged 1 commit into from
Oct 2, 2013

Conversation

nbrochu
Copy link
Contributor

@nbrochu nbrochu commented Feb 15, 2012

Simple fix to silence the following warning in JRuby:

.../gems/log4r-1.1.10/lib/log4r/formatter/patternformatter.rb:126 warning: Ambiguous first argument; make sure.

No need to actually merge since it's such a trivial fix. You can add the parentheses yourself if you prefer for 1.1.11. Adding them obviously doesn't affect other Ruby interpreters as it is still valid syntax.

Just letting you know.

colbygk added a commit that referenced this pull request Oct 2, 2013
Wrapped an argument in parentheses to silence JRuby "Ambiguous First Argument" warnings
@colbygk colbygk merged commit 24d8325 into colbygk:master Oct 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants