Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Add methods for margin endpoints #39

Merged
merged 2 commits into from Apr 3, 2017
Merged

Add methods for margin endpoints #39

merged 2 commits into from Apr 3, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2017

Copy link
Contributor

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that

  • forEach is part of the Array prototype for ES6.
  • const or let is preferred over var for ES6

@ghost
Copy link
Author

ghost commented Apr 3, 2017

Great points. Just maintaining consistency with the rest of the lib for this. But I'll submit a PR updating that for the whole lib after this. Thanks

@CjS77
Copy link
Contributor

CjS77 commented Apr 3, 2017

Yes, I agree. Consistency > Implementing new features for a subset of code.

@CjS77 CjS77 merged commit 98d044e into coinbase:master Apr 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant