Rewrite the GIF frame delay if it's below a threshold. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Support rewriting GIF frame delay in GifDecoder. * Temporary debug code. * Abstract out frame delay rewriter. * Fix rewriter. * Convert to a forwarding source. * Rename. * Revert "Temporary debug code." This reverts commit 94cd76d. * Add tests. * Reduce change of artifacts.
FooIbar
added a commit
to FooIbar/EhViewer
that referenced
this pull request
Jan 14, 2023
FooIbar
added a commit
to FooIbar/EhViewer
that referenced
this pull request
Jan 14, 2023
asuka-mio
pushed a commit
to Ehviewer-Overhauled/Ehviewer
that referenced
this pull request
Jan 14, 2023
…) (#672) * Rewrite the GIF frame delay if it's below a threshold (coil-kt/coil#783) Resolve #641 * fixup! Rewrite the GIF frame delay if it's below a threshold (coil-kt/coil#783)
asuka-mio
added a commit
to Ehviewer-Overhauled/Ehviewer
that referenced
this pull request
Jan 16, 2023
…t/coil#783) (#672)" This reverts commit 0ebb555.
|
No longer need that workaround on Android 14 above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #540
Adds an
enforceMinimumFrameDelayconstructor arg toGifDecoderandImageDecoderDecoderthat enables rewriting the GIF's frame delay if it's below a threshold (we use the same values as major web browsers + Glide).There's a very small chance that this fix introduces visual artifacts since it scans the source for a magic sequence instead of implementing a complete GIF parser so
enforceMinimumFrameDelayis currently disabled by default.