Fix decoding high colour depth images. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Fix decoding high colour depth images. * Update API. * Fix test. * Refactor. * Fix test. * Fix tests. * Rename tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High colour depth images (e.g. 16 bit pngs) can only be decoded by
BitmapFactoryasRGBA_F16. At the moment, we don't handle this properly and can accidentally allocate a bitmap that's too small to decode into.This PR handles allocating a larger bitmap in this case. It also relaxes some cache checks around bitmap config. I think as long as
allowHardwareis strictly respected, the exact software bitmap config (RGB_565,ARGB_8888,RGBA_F16) should be considered best effort.