Fix failing to read EXIF data on pre-API 23. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
changed the title
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured this out while working on #330.
AlwaysAvailableInputStreamreturnsInt.MAX_VALUEforavailable(). This seems to work fine on API 23+, but will cause an int overflow inBufferedInputStream.available(). Then whenExifInterfacereads the stream it throws anEOFExceptionbecauseavailableis negative.To fix this, we still use a really large number (1GB) that has no chance of overflowing.
This case is covered by tests in #330.
Fixes: #250