Ensure View dimensions are evaluated to at least 1px. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jawnnypoo
reviewed
Aug 14, 2019
| viewTreeObserver.removePreDrawListenerSafe(this) | ||
| val width = max(1, view.width - view.paddingLeft - view.paddingRight) | ||
| val height = max(1, view.height - view.paddingTop - view.paddingBottom) | ||
| continuation.resume(PixelSize(width, height)) |
There was a problem hiding this comment.
!isResumed check no longer needed?
There was a problem hiding this comment.
Actually, I didn't think we did initially, but I'm going to leave it in for safety. It's to prevent resuming the continuation twice, which would throw an exception.
Jawnnypoo
previously approved these changes
Aug 14, 2019
colinrtwhite
force-pushed
the
colin/fix_wrap_content
branch
from
fff0b90
to
656d75e
Compare
Jawnnypoo
approved these changes
Aug 14, 2019
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Ensure View dimensions are at least 1px. * Re-add resumed check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20
This fixes the case where one or more of a View's dimensions resolves to 0px. In this case, we treat the dimension as 1px. Image dimensions must be loaded with all dimensions > 0 so this saves us from handling a lot of complexity later in the image pipline.