Use rememberCoroutineScope in AsyncImagePainter. #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlykotom
reviewed
Apr 29, 2024
coil-compose-core/src/commonMain/kotlin/coil3/compose/AsyncImagePainter.kt
Outdated
Show resolved
Hide resolved
colinrtwhite
force-pushed
the
colin/async_image_painter_scope
branch
from
5791917
to
a7afc26
Compare
mlykotom
reviewed
Jun 24, 2024
Comment on lines
+197
to
+200
| set(value) { | ||
| field?.cancel() | ||
| field = value | ||
| } |
There was a problem hiding this comment.
@colinrtwhite I think here's a slight bug that causes the image to start loading later than necessary.
Because you're not checking for if(value == field) return, the onRemembered() call is first called manually and then by the Compose framework, which means that there will be two requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181.