Use Java 17 on CI. #1140
Merged
Use Java 17 on CI. #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Feb 14, 2022
| @@ -17,7 +17,8 @@ jobs: | |||
| - uses: actions/setup-java@v2 | |||
| with: | |||
| distribution: 'adopt' | |||
| java-version: 11 | |||
| java-version: 17 | |||
There was a problem hiding this comment.
Suggesting use zulu instead of adopt,
https://api.adoptopenjdk.net/
There was a problem hiding this comment.
@Goooler What's the benefit? I thought zulu was best for M1 Macs, though I don't think the Github Mac runners are M1.
There was a problem hiding this comment.
As Jake recommending this.😃
There was a problem hiding this comment.
Sounds good to me :)
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Use Java 17 on CI. * Enable cache. * Use zulu. * Don't cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.