-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
older versions of libsystemd lack all functions use for our bus
module
#132
Comments
We have a similar problem with In my opinion, a feature flag is not necessary for systemd versions which are already in the stable branches of the major Linux distributions. On Debian stable it is currently version 241 (https://packages.debian.org/buster/libsystemd-dev). But there should be flags for newer versions. I am not familiar with the systemd API, so I cannot provide a pull request for all API changes. But I could create a pull request with the |
I think starting with a systemd_v245 feature flag makes sense here. We need some solution for this, and that seems like a minimal one. I'm fine with the feature not being 100% accurate (missing some API items) initially, it'll be better than the current situation. |
Similar situation here, hitting a linking issue due to missing |
200: Add feature flag for systemd version 245 r=jmesmon a=siegfriedweber The method `sd_journal_open_namespace` was added in systemd v245 (see the [systemd changelog](https://github.com/systemd/systemd/blob/v245/NEWS#L79-L86)). This version is not yet available in the stable branches of some major Linux distributions, for instance in Debian 10 which contains version 241 (https://packages.debian.org/buster/libsystemd-dev). This pull request adds the feature flag `systemd_v245`. `sd_journal_open_namespace` is only available if this feature flag is set. This is the first step to fix issue #132. Co-authored-by: Siegfried Weber <[email protected]>
In particular, ubuntu-18.04's libsystemd lacks 2 functions which result in link errors (when the
bus
feature is not disabled):We should consider looking into whether these can be avoided an provide a usable API in
systemd
(high level crate). Possible thatbus
(the feature) could be subsetted (so some of bus is usable with oldlibsystemd
. Minimally, detecting the presence of these functions at configuration time and avoiding emitting the rust definitions would help us get better errormessages (ie: at compile instead of at link).
openssl has to deal with similar issues and probably has some approach we can adapt.
The text was updated successfully, but these errors were encountered: