NMAP in config.json #114
Merged
NMAP in config.json #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Just one last change - could you update the readme.md to address the docker file? I'll do a full test/review of this as soon as I can. |
…o contain snmp and nbtscan
|
Updated README with instructions for usage. Do you think that is sufficient? Or would more instructions be necessary? |
codingo
approved these changes
Oct 4, 2019
|
That's perfect, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of nmap as a standalone option in the config file.
Added method to grab key, value from config.
Use of fstrings
Addition of Dockerfile
requirements.txt for potential future usage and solo requirement of requests
Please let me know your thoughts.