Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): improve block constructor options types #2749

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

neSpecc
Copy link
Member

@neSpecc neSpecc commented Jun 29, 2024

Problem

We have a mistake in the BlockToolConstructorOptions options: block and config types marked as optional but they are always assigned.

And tools developers had to check them for emptiness, which is useless:

image

Cause

Probably it was added for supporting of old tools, but old tools should use old version of editor.

Solution

block and config became not-optional

@neSpecc neSpecc merged commit 897be41 into next Jun 29, 2024
6 checks passed
@neSpecc neSpecc deleted the block-constructor-types branch June 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants