Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: remove bundles #1541

Merged
merged 8 commits into from
Feb 18, 2021
Merged

Feature: remove bundles #1541

merged 8 commits into from
Feb 18, 2021

Conversation

talyguryn
Copy link
Member

Remove bundles for easy merging.

Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not be merged without github action for bundling

UPD: not actual. Forgot that we build it on NPM publishing ci

@@ -27,6 +27,9 @@
</div>
<div class="ce-example__content _ce-example__content--small">
<div id="editorjs"></div>
<div id="hint-core" style="text-align: center;">
No core bundle file found. Run <code class="inline-code">yarn build</code>
</div>
<div id="hint" style="text-align: center;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div id="hint" style="text-align: center;">
<div id="hint-tools" style="text-align: center;">

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

example/example-i18n.html Show resolved Hide resolved
@talyguryn talyguryn merged commit fbd4bd9 into next Feb 18, 2021
@talyguryn talyguryn deleted the feature/remove-bundles branch February 18, 2021 11:06
@neSpecc neSpecc mentioned this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants