Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the result of block.call #1205

Merged
merged 33 commits into from
Aug 18, 2020
Merged

Return the result of block.call #1205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f5e9a66
[Improvements] ESLint action (#1099)
neSpecc Apr 11, 2020
4c0d806
[Refactor] ESLint fixed (#1100)
gohabereg Apr 18, 2020
21cac86
[Feature] i18n (#1106)
neSpecc Apr 20, 2020
775ccbc
Remove unused submodule
tasuku-s Apr 23, 2020
f4c4051
Fixed: icon centering in Firefox
neSpecc Apr 25, 2020
2997ed0
Do not load styles twice (#1112)
gohabereg Apr 25, 2020
4a81699
Show warning if Block to delete is not found (#1111)
gohabereg Apr 25, 2020
7eb642d
Save Tools' order in the Toolbox (#1113)
gohabereg Apr 25, 2020
72213f2
fix $.isEmpty performance (#1096)
tasuku-s Apr 25, 2020
7f876e8
Add issue templates (#1114)
gohabereg Apr 25, 2020
66e70fa
Update issue templates (#1121)
neSpecc Apr 25, 2020
5218a6a
Allowing deleting block by block id (#1108)
athul7744 Apr 25, 2020
ae8591c
Allow navigate next from last non-initial block (#1110)
gohabereg Apr 25, 2020
f6b7b2e
Create CODE_OF_CONDUCT.md (#1171)
talyguryn May 27, 2020
e3410be
Update dependencies (#1122)
gohabereg May 27, 2020
b0ddb10
Feature/disable tab event config (#1164)
flaming-cl May 27, 2020
1eb6d81
Highlight first block on autofocus (#1127)
gohabereg May 27, 2020
5fe8b08
Fix shortcut for external tools (#1141)
sonnn May 27, 2020
7c3bf76
Hotfix/issue1133 selection shortcut removed on editor destroy (#1140)
sis-dk May 27, 2020
ffe5bbc
[Feature] BlockAPI Interface (#1075)
gohabereg May 27, 2020
ff6bd2d
Fix BlockManager.insert method (#1172)
gohabereg Jun 2, 2020
e1500f7
Update tools master branches (#1180)
talyguryn Jun 2, 2020
26b19a3
Fix behaviour of inputs editing in block settings (#1123)
gohabereg Jun 2, 2020
8341c33
Merge branch 'master' into release/2.18
neSpecc Jun 2, 2020
239aaf6
lint code
neSpecc Jun 3, 2020
4cea66f
Update CHANGELOG.md
neSpecc Jun 3, 2020
3219030
Return the result of block.call
jacobsmith Jun 17, 2020
6749013
Merge branch 'next' of github.com:codex-team/editor.js into pr/1205
gohabereg Jul 26, 2020
4382a60
Disable ESLint for call method return value
jacobsmith Aug 6, 2020
03fde39
Change any type to unknown and add to CHANGELOG.md
ranemihir Aug 14, 2020
8e29efb
Add unknown to eslint globals
ranemihir Aug 14, 2020
ac4eab7
upd
neSpecc Aug 18, 2020
8d12488
Merge branch 'next' into pr/1205
neSpecc Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix $.isEmpty performance (#1096) 
* fix $.isEmpty performance

* add changelog

* upd bundle

Co-authored-by: Peter Savchenko <[email protected]>
  • Loading branch information
@tasuku-s @neSpecc
tasuku-s and neSpecc committed Apr 25, 2020
commit 72213f2cd39fed4565e148d87b4485031f771d6d
2 changes: 1 addition & 1 deletion dist/editor.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- `Fix` - Editor's styles won't be appended to the `<head>` when another instance have already do that [#1079](https://github.com/codex-team/editor.js/issues/1079)
- `New` *I18n API* — Ability to provide internalization for Editor.js core and tools. [#751](https://github.com/codex-team/editor.js/issues/751)
- `Fix` - Fixed wrong toolbar icon centering in Firefox [#1120](https://github.com/codex-team/editor.js/pull/1120)
- `Improvements` - Improve performance of DOM traversing at the `isEmpty()` method [#1095](https://github.com/codex-team/editor.js/issues/1095)
- `Fix` - Toolbox: Tool's order in Toolbox now saved in accordance with `tools` object keys order [#1073](https://github.com/codex-team/editor.js/issues/1073)

### 2.17
Expand Down
38 changes: 6 additions & 32 deletions src/components/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,23 +384,12 @@ export default class Dom {
* @returns {boolean}
*/
public static isEmpty(node: Node): boolean {
const treeWalker = [],
leafs = [];

if (!node) {
return true;
}

if (!node.childNodes.length) {
return this.isNodeEmpty(node);
}

/**
* Normalize node to merge several text nodes to one to reduce tree walker iterations
*/
node.normalize();

treeWalker.push(node.firstChild);
const treeWalker = [ node ];

while (treeWalker.length > 0) {
node = treeWalker.shift();
Expand All @@ -409,31 +398,16 @@ export default class Dom {
continue;
}

if (this.isLeaf(node)) {
leafs.push(node);
} else {
treeWalker.push(node.firstChild);
}

while (node && node.nextSibling) {
node = node.nextSibling;

if (!node) {
continue;
}

treeWalker.push(node);
if (this.isLeaf(node) && !this.isNodeEmpty(node)) {
return false;
}

/**
* If one of child is not empty, checked Node is not empty too
*/
if (node && !this.isNodeEmpty(node)) {
return false;
if (node.childNodes) {
treeWalker.push(...Array.from(node.childNodes));
}
}

return leafs.every((leaf) => this.isNodeEmpty(leaf));
return true;
}

/**
Expand Down