new sanitize method #103
Merged
new sanitize method #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Dec 30, 2016
| @@ -224,6 +234,8 @@ var callbacks = (function(callbacks) { | |||
|
|
|||
| callbacks.redactorClicked = function (event) { | |||
|
|
|||
| callbacks.isClickedOnFirstLevelBlockArea(); | |||
There was a problem hiding this comment.
название должно четко соответствовать поведению: сейчас выглядит как будто функция возвращает булен
| * clicked in redactor area | ||
| * @type {null | Boolean} | ||
| */ | ||
| content.editorArea = null; |
neSpecc
requested changes
Jan 10, 2017
| @@ -517,7 +557,7 @@ var content = (function(content) { | |||
| tool = workingNode.dataset.tool; | |||
|
|
|||
| if (codex.tools[tool].allowedToPaste) { | |||
| codex.content.sanitize(mutation.addedNodes); | |||
| (codex.content.sanitize.bind(this, mutation.addedNodes))(); | |||
| mutations.forEach(codex.content.paste); | ||
|
|
||
| var self = this, | ||
| callback; |
| * For that, we need to send Context, MutationObserver.__proto__ that contains | ||
| * observer disconnect method. | ||
| */ | ||
| console.warn('mutations count: %o', mutations.length); |
| @@ -545,92 +585,70 @@ var content = (function(content) { | |||
| * | |||
| * Sanitizes HTML content | |||
| * @param {Element} target - inserted element | |||
| * @uses DFS function for deep searching | |||
| * @uses Sanitize library and BASIC configuration | |||
| var sanitizer = new janitor(Config), | ||
| clear = sanitizer.clean(node.outerHTML); | ||
|
|
||
| var newFragment = document.createElement('DIV'); |
| */ | ||
| block.addEventListener('paste', function (event) { | ||
| codex.callback.blockPaste(event); | ||
| codex.callback._blockPaste(event); |
neSpecc
pushed a commit
that referenced
this pull request
Jan 10, 2017
* start versioning * codex.version * eslint settings * versioning improved * cover restoring and fetch function fixed (#101) * cover restoring fixed * upd * fetch fixed in safari * updated * plugins * plugins ready * code improved * fixed bug with backspace * improved architecture * new sanitize method (#103) * new sanitize method Need to fix caret position * removed console logs * version updated * eslint style * caret position * big fixed on sanitize method * sanitize improved, using observers * sanitize: using html-janitor * fixes * last fixes, code improved after review * updated * new bundle * webpack config improved * upd * upd * upd
neSpecc
pushed a commit
that referenced
this pull request
Jan 10, 2017
#105) * cover restoring fixed * upd * fetch fixed in safari * updated * plugins * plugins ready * code improved * fixed bug with backspace * improved architecture * Versioning (#102) * start versioning * codex.version * eslint settings * versioning improved * cover restoring and fetch function fixed (#101) * cover restoring fixed * upd * fetch fixed in safari * updated * plugins * plugins ready * code improved * fixed bug with backspace * improved architecture * new sanitize method (#103) * new sanitize method Need to fix caret position * removed console logs * version updated * eslint style * caret position * big fixed on sanitize method * sanitize improved, using observers * sanitize: using html-janitor * fixes * last fixes, code improved after review * updated * new bundle * webpack config improved * upd * upd * upd * upd * clear from conflicts * upd * upd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix caret position